Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve base branch selection in compare #880

Merged
merged 3 commits into from
Sep 8, 2023
Merged

[Feature] Improve base branch selection in compare #880

merged 3 commits into from
Sep 8, 2023

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Sep 7, 2023 •
edited
Loading

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
feature

What this PR does / why we need it:

  • When piperider compare is executed, piperider automatically generates a recipe for users.
  • We need a better way to give users a hint to specify the base branch and deal with the branch not found problem.

Which issue(s) this PR fixes:
sc-32156
#866

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #880 (52a79ad) into main (47999a3) will decrease coverage by 0.06%.
Report is 6 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   46.46%   46.40%   -0.06%     
==========================================
  Files          75       75              
  Lines       10341    10356      +15     
==========================================
+ Hits         4805     4806       +1     
- Misses       5536     5550      +14
Files Changed Coverage Δ
piperider_cli/cli.py 65.10% <ø> (ø)
piperider_cli/recipe_executor.py 0.00% <0.00%> (ø)
piperider_cli/recipes/default_recipe_generator.py 0.00% <0.00%> (ø)
piperider_cli/recipes/utils.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115
Change hint message wording
52a79ad 
Signed-off-by: Wei-Chun, Chang <[email protected]>
@wcchang1115 wcchang1115 marked this pull request as ready for review September 7, 2023 10:16
kentwelcome
kentwelcome approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@kentwelcome kentwelcome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcchang1115 wcchang1115 merged commit f989023 into main Sep 8, 2023
30 of 31 checks passed
@sentry-io
Copy link

sentry-io bot commented Sep 14, 2023 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RecipeException: Cannot find specified base branch: test/test-branc piperider_cli.recipes.default_recipe_generator ... View Issue
  • ‼️ RecipeException: Cannot find specified base ref: abc piperider_cli.recipes.default_recipe_generator ... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentwelcome kentwelcome kentwelcome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcchang1115 @kentwelcome